Dance page - style Amazon logo section #25950
Conversation
|
Your checklist in your PR description is unchecked. Are you still working on things or is it ready for review? For example, you said you removed the colon but the After screenshot still has it. |
| .sponsor-logo-with-text .sponsor-logo-image { | ||
| margin-top: 10px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Missing new line at the end of the file
| %p= I18n.t(:hoc2018_dance_amazon_sponsor_section_with_logo_title) | ||
| %div | ||
| %img{src:"/images/fit-450/AFE-Dark-Orange-logo.png"} | ||
| %div.sponsor-logo-with-text{style: "font-size: 24px; text-align: center; margin-top: 60px"} |
There was a problem hiding this comment.
Nit: I like to keep my HAML as clean as possible. If there is an id or class, you can remove the %div part.
Also, these in-line styles can be moved to your css file.
There was a problem hiding this comment.
Same for line 6 and throughout the file.
|
@tanyaparker It will be visible after content scoop today at noon. I will update PR with screen shot. The i18n gsheet has been updated. |
|
You could either 1) ssh into staging, scoop it, merge staging into your branch again or 2) temporarily edit your pegasus/cache/i18n/en-US.yml file with the same change but don't commit it so that you can preview your changes locally. So are you waiting to check off the checklist until after you merge your PR? |
|
@tanyaparker updated i18n strings have been merged onto staging, updated code per feedback. Ready for review. Thanks |
| margin-right: 18%; | ||
| } | ||
|
|
||
| @media screen and (min-width: 0px) and (max-width: 512px) { |
There was a problem hiding this comment.
I don't think you need to have a separate css file just for the logo classes. I'd put this inside the dance.css file which should have all the styles needed for /dance.
| @@ -1,9 +1,10 @@ | |||
| %link{:rel=>'stylesheet', :type=>'text/css', :href=>'/css/dance-landing/dance-sponsor-logo.css'} | |||
| %link{href: "/css/dance-landing/dance.css", type: "text/css", rel: "stylesheet"} | |||
There was a problem hiding this comment.
You don't need to load this again since it's already loaded on dance.haml.
This PR is to style the amazon log section
Implementation
screen shot
-After (at smaller width)