Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy of amazon boxes on /dance #25960

Merged
merged 1 commit into from Nov 9, 2018
Merged

Update copy of amazon boxes on /dance #25960

merged 1 commit into from Nov 9, 2018

Conversation

tanyaparker
Copy link
Contributor

@tanyaparker tanyaparker commented Nov 9, 2018 •
edited

I removed the box# from the keys because these boxes may get rearranged later and then it'll be confusing to keep track of which one is which. They already have unique identifiers like scholarship_programs or internships. I also eliminated the long and short since we know which copy we want and we don't need both versions.

image

nkiruka
nkiruka approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@nkiruka nkiruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanyaparker tanyaparker merged commit 04cb281 into staging Nov 9, 2018
@tanyaparker tanyaparker deleted the amazon-strings branch November 9, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkiruka nkiruka nkiruka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanyaparker @nkiruka