Homepage: fix last action block #25989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems with the final action block switching between "dance" and "mc" modes: - Only one of them needed to go to a studio.code.org URL - The function was caching its result, and so a change of the DCDO "hoc_launch" flag wasn't actually leading to a new block upon page refresh
maddiedierker
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
thank you for this! i'm going to close #25987 since you also fixed the caching issue here
|
heads up @breville that i'm going to merge this for you so it can go out today (and you're probably sleeping)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with the final action block switching between "dance" and "mc" modes: