Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go back to jquery clicks in minecraft i18n scenarios #26098

Merged
merged 1 commit into from Nov 15, 2018

Conversation

davidsbailey
Copy link
Member

reverts a small part of https://github.com/code-dot-org/code-dot-org/pull/26043/files#diff-c222c7ca383f3bfd6665e3dfcdd60b02 . That PR caused failures on test not caught by circle due to the @no_circle flag.

@maddiedierker
Copy link
Contributor

looking at the test failure here, i'm wondering if the failure is legitimate. the error is:

And I press "toggleButton"
unknown error: Element is not clickable at point (939, 102). Other element would receive the click: <div class="modal-backdrop  in"></div>

wouldn't this suggest that the toggleButton is hidden by modal element in Spanish? not that this is your responsibility to fix; i'm more wondering if it's a bug we need to track in non-English languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants