Volunteer: fix unsubscribe for users without email preference #26115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who had volunteered before we added the email preference weren't able to modify subscription preferences because the server was enforcing a requirement that there be an emai preference. This adds the email preference dropdown to the "Update email preferences" UI. It's not mandatory if the user already has an email preference, but if they don't, submitting the form will give an error that a value needs to be provided.
|
Note that the dropdown doesn't currently show the existing email preference on either of the dropdowns on this page. |
tanyaparker
approved these changes
Nov 16, 2018
|
Not related to your PR, but I'm wondering if we can fix while we're in here. The 18+ checkbox should have a red asterisk.
|
|
If the email dropdown isn't required, then it shouldn't have the red asterisk. |
When adjusting volunteer subscription preference, a red asterisk is now always shown by the 18+ option. Also, if there isn't already an email preference, a red asterisk is shown by that choice too.
maddiedierker
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who had volunteered before we added the email preference weren't able to modify subscription preferences because the server was enforcing a requirement that there be an email preference.
This adds the email preference dropdown to the "Update email preferences" UI.
It's not mandatory if the user already has an email preference, but if they don't, submitting the form will give an error that a value needs to be provided.
(Also, the red asterisk next to email preference is only shown if we don't already have one on record.)
This is similar to the 18+ fix made in #14622.
Also made a couple small fixes to
/volunteer/local: when contacting a volunteer, the initiating user'sage_18_plus_bvalue is now written properly in theVolunteerContact2015form, and fields highlighted for errors are returned to normal when the form is submitted successfully.