New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable social buttons for users under 13 #26127
Conversation
Based on screenshots: why are we hiding the "send to phone" button in the finish dialog, but not in the share dialog? |
@Erin007 that's a good question! the existing functionality for signed in users works the same way, but i honestly don't know why. @ryansloan -- signed in users under 13 currently see the "share to phone" button in the share dialog, but it's hidden in the finish dialog (screenshots below). should this button be shown or hidden for users under 13? Share dialog (user under 13 sees "share to phone"): Finish dialog (user under 13 does not see "share to phone"): |
@madelynkasula Send to phone should be visible for under 13, as confirmed by Privacy Czar. If we can show it in Finish as part of this that would be great. |
@ryansloan will do! @Erin007, thanks for bringing that up |
Depends on #26154.
Fixes this issue in dance party.
Since we ask signed out users for their age before using Dance Party, we can use that age to decide whether to hide social share (Facebook and Twitter) buttons. Now, we will hide social share for all users under 13 (whether or not they are authenticated).
Finish dialog
Before:
After:
Share dialog
Before:
After: