Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable social buttons for users under 13 #26127

Merged
merged 13 commits into from Nov 26, 2018
Merged

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Nov 16, 2018

Depends on #26154.

Fixes this issue in dance party.

Since we ask signed out users for their age before using Dance Party, we can use that age to decide whether to hide social share (Facebook and Twitter) buttons. Now, we will hide social share for all users under 13 (whether or not they are authenticated).

Finish dialog

Before:
screen shot 2018-11-20 at 10 21 26 am

After:
screen shot 2018-11-20 at 10 19 27 am

Share dialog

Before:
screen shot 2018-11-20 at 10 21 33 am

After:
screen shot 2018-11-20 at 10 19 38 am

@Erin007
Copy link
Contributor

Erin007 commented Nov 16, 2018

Based on screenshots: why are we hiding the "send to phone" button in the finish dialog, but not in the share dialog?

@maddiedierker
Copy link
Contributor Author

@Erin007 that's a good question! the existing functionality for signed in users works the same way, but i honestly don't know why.

@ryansloan -- signed in users under 13 currently see the "share to phone" button in the share dialog, but it's hidden in the finish dialog (screenshots below). should this button be shown or hidden for users under 13?

Share dialog (user under 13 sees "share to phone"):
screen shot 2018-11-15 at 10 09 10 pm

Finish dialog (user under 13 does not see "share to phone"):
screen shot 2018-11-15 at 10 09 21 pm

@ryansloan
Copy link
Contributor

@madelynkasula Send to phone should be visible for under 13, as confirmed by Privacy Czar. If we can show it in Finish as part of this that would be great.

@maddiedierker
Copy link
Contributor Author

@ryansloan will do! @Erin007, thanks for bringing that up

@maddiedierker maddiedierker changed the base branch from staging to signed-out-age-dialog November 20, 2018 06:29
@maddiedierker maddiedierker changed the base branch from signed-out-age-dialog to staging November 20, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants