Disable locale-specific links to CurriculumBuilder #26138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that enabling a language here will redirect _all_ links to CB for that language to the language-specific version of that content, even though we only generate language-specific versions of CB content for the subset of content we are actively translating. This results in all CB links except for that subset being broken. We are disabling languages for now until we can figure out a more precise way to link to CB content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that enabling a language here will redirect all links to
CB for that language to the language-specific version of that content,
even though we only generate language-specific versions of CB content
for the subset of content we are actively translating.
This results in all CB links except for that subset being broken. We are
disabling languages for now until we can figure out a more precise way
to link to CB content.