Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate "send to phone" on ShareAllowedDialog #26202

Merged
merged 1 commit into from Nov 26, 2018
Merged

Translate "send to phone" on ShareAllowedDialog #26202

merged 1 commit into from Nov 26, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Nov 23, 2018

Use the translated string "Send to phone" rather than use the hardcoded English.

Fixes issue: #443

BEFORE:
screen shot 2018-11-23 at 12 54 25 pm

AFTER:
screen shot 2018-11-23 at 1 33 43 pm

@Erin007 Erin007 added the i18n label Nov 23, 2018
@Erin007 Erin007 requested a review from nkiruka November 23, 2018 18:47
@Erin007 Erin007 mentioned this pull request Nov 23, 2018
Closed
nkiruka
nkiruka approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@nkiruka nkiruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Erin007 Erin007 merged commit 2a667b4 into staging Nov 26, 2018
@Erin007 Erin007 deleted the translate-send-to-phone branch November 26, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkiruka nkiruka nkiruka approved these changes

Assignees
No one assigned
Labels
i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erin007 @nkiruka