Separate tutorial landing page UI tests #26220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
force-pushed
the
other-sites-feature
branch
from
b5a1457
to
8130194
Compare
davidsbailey
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other_sites.featureincludes visiting a long list of pages, which means its re-run time is long. On my most recent DotD shift re-runs of this test took nearly 20 minutes to fail and almost 12 minutes to pass. This PR moves test coverage for the tutorial landing pages into a separate file so they can be run in parallel, and each sub-set will take less time if re-runs are needed. Some duplicated code in the set-up seems a fair tradeoff for reduced testing time.