Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out MobileControls class from GameLab class #26280

Merged
merged 4 commits into from
Dec 14, 2018
Merged

Factor out MobileControls class from GameLab class #26280

merged 4 commits into from
Dec 14, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Nov 30, 2018

  • In preparation for solving mobile controls with GameLab export, I have factored out all of the code needed for handling the d-pad, space button, and optional arrow buttons into a separate class called MobileControls
  • NOTE: the UI is still rendered in GameLabVisualizationColumn.jsx

@islemaster
Copy link
Contributor

This extraction looks great. Just capturing an earlier conversation, I'm still on-board for the follow-up moving the associated DOM out of React. Also since we've just switched back to our regular pipeline don't forget to change base to staging.

@cpirich cpirich changed the base branch from staging-next to staging December 14, 2018 18:29
@cpirich cpirich merged commit 071c451 into staging Dec 14, 2018
@cpirich cpirich deleted the factor_out_mobile_controls_from_gamelab_class branch December 14, 2018 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster