Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change replay button text to be centered #26282

Merged
merged 1 commit into from Dec 5, 2018

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Nov 30, 2018

Issue: code-dot-org/dance-party#354

Before:
image

After:
Chrome/DanceParty
danceparty

IE/Applab
applabie

Mobile/DanceParty
screenshot_20181130-113130_chrome

@Hamms
Copy link
Contributor

Hamms commented Nov 30, 2018

Interestingly, it looks like we actually override the margins for this element in several of the places we use it. In particular, compare the buttons on https://staging-studio.code.org/s/coursea-2018/stage/4/puzzle/7 with those in /s/dance.

I'd be inclined to do a more surgical change for this, and instead just add text-align: center to the #again-button:not(.arrow-container) { definition here

#again-button:not(.arrow-container) {
background-color: $green;
border: 1px solid $green;
color: white;
margin-left: 0px;
margin-right: 10px;
}
#continue-button:not(.arrow-container), #confirm-button:not(.arrow-container) {
background-color: $orange;
border: 1px solid $orange;
color: white;
margin-left: 0px;
margin-right: 10px;
text-align: center;
}

@jmkulwik jmkulwik merged commit 75f5a74 into staging-next Dec 5, 2018
@jmkulwik jmkulwik deleted the center-replay-button-text branch December 5, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants