Refactor Starwars tutorial haml to be more generalizable #26289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Dec 4, 2018
breville
reviewed
Dec 4, 2018
nkiruka
reviewed
Dec 4, 2018
maddiedierker
approved these changes
Dec 4, 2018
This was referenced Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our tutorial landing pages we have 3 very similar components that are all currently using Starwars styling and selectors since they were built quickly to hit HoC deadlines:
Starwars
Minecraft
Dance
It's also very likely that we will want to use a similar component in the future.
This PR is the first in a series to extract the skeleton of the Starwars version of the component and its stylings into a more general, reusable haml partial. This PR affects only code.org/starwars. Follow up PR will address the other 2 components and delete the styles duplication.
There should be no user impact with this refactor, and there are eyes tests on the Starwars landing page, which should catch any regressions.
English // Desktop // Before
English // Desktop // After
English // Mobile // Before
English // Mobile // After
non-English // Desktop // Before
non-English // Desktop // After
non-English // Mobile // Before
non-English // Mobile // After
