Teacher dashboard navigation - tab switching in context #26333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
I really like where this is going, and don't have a problem with merging this. Before you get too much further though, have you looked at react-router? I believe PLC has used it, and it does something very similar to what you've implemented here.
| import React, {Component, PropTypes} from 'react'; | ||
| import NavigationBar from '../NavigationBar'; | ||
|
|
||
| export const teacherDashboardLinks = [ |
There was a problem hiding this comment.
this is repeated in a few places, so i think it would do well as a type, similar to how we set up types in manageStudentsRedux. maybe it would be something like:
const TeacherDashboardNavType = {
MANAGE_STUDENTS: {
label: "Manage Students",
url: "manage_students"
},
...
}
|
@madelynkasula I consolidated the routes and pass in @tab. I'm going to merge this now and continue cleaning up/refactoring as the work progresses. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #26308
I set up a new teacher_dashboard_controller and a base route to
teacher_dashboard/sections/:section_id/. I also route the versions of the links for each teacher dashboard tab back to the index and usewindow.history.replaceState(null, null, linkUrl);to modify the url when a new tab is clicked. In the result, going tostudio.code.org/teacher_dashboard/sections/:section_id/defaults to the progress tab (which is consistent with the current behavior on Pegasus) and going tostudio.code.org/teacher_dashboard/sections/:section_id/<tab_name>will put you on the new teacher dashboard page with the correct tab selected. Ifstudio.code.org/teacher_dashboard/sections/:section_id/<tab_name>is refreshed, you stay with the correct tab selected. Navigating back from the teacher_dashboard index will take you wherever you were before, not to the tab you most recently selected.