Banners: professional learning 2019 for homepage, teacher /home & /courses #26577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Jan 12, 2019
Erin007
reviewed
Jan 12, 2019
| lineHeight: 1.2, | ||
| fontFamily: '"Gotham 7r", sans-serif', | ||
| color: color.white | ||
| }, |
There was a problem hiding this comment.
We could extract the common styles between subHeading and subHeadingSmallFont and then set the font size only with the conditional below, but I don't feel strongly about it.
Erin007
approved these changes
Jan 12, 2019
|
@Erin007 good point. We since decided to make this announcement en-only on /home, as it already was on /courses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code.org/
teacher /home
teacher /courses
Additional images are included for potential a/b testing.