Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup HAML/React - Regional Partner Playbook #26592

Merged
merged 4 commits into from Jan 15, 2019
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jan 14, 2019

replace the educate_box.haml template with the equivalent ResourceCard.jsx component on https://code.org/educate/regional-partner/playbook

The visual change has been approved by relevant stakeholders.

Before After
image image

@Hamms Hamms requested a review from Erin007 January 14, 2019 21:47
theme: responsive
---

%meta{name: 'robots', content: 'noindex'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tells scrapers to ignore this page; I'm not sure why we'd want that, but it's present in the current version so I preserved it

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! One little question for my own curiosity, but LGTM!

@Hamms Hamms merged commit c1bfabf into staging Jan 15, 2019
@Hamms Hamms deleted the dedup-resource-card branch January 15, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants