Fixing NoMethodError: undefined method `+' for nil:NilClass #26677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehalshah
approved these changes
Jan 22, 2019
| @@ -99,7 +99,20 @@ def has_k8_grades? | |||
| end | |||
|
|
|||
| def urm_percent | |||
| percent_of_students(student_am_count + student_hi_count + student_bl_count + student_hp_count) | |||
| total_urm_students = 0 | |||
There was a problem hiding this comment.
Suggest
[student_am_count, student_hi_count, student_bl_count, student_hp_count].compact.reduce(:+) instead for compactness
There was a problem hiding this comment.
Done. Thanks!
clareconstantine
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Honeybadger error that occurs when trying to generate a csv when some student counts are nil and some aren't.