Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tertiary tint color to follow the pattern #26704

Merged
merged 1 commit into from Jan 23, 2019

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented Jan 23, 2019

Super small fix to make the tertiary tint colors be equally spaced around the color wheel. I verified existing solutions won't be affected (they store the old hex value directly in the XML).

<block type="Dancelab_setTintInline">
  <title name="SPRITE">dancer1</title>
  <title name="VAL">#0088ff</title>
</block>

Before:

image

After:

image

@davidsbailey
Copy link
Member

The code change looks fine, however we should probably pick these for how they look on the screen and not how they look in the code:

with light blue:
screen shot 2019-01-23 at 10 32 48 am

with lime:
screen shot 2019-01-23 at 10 33 40 am

The green is pretty intense so I think the lime option actually fills in the gaps in color choices nicely!

To go on a bit, there are actually 6 tertiary colors. The other 3 "evenly spaced" colors don't seem to look as good for some reason, especially the super intense pink/red:
screen shot 2019-01-23 at 10 42 24 am

CC @ryansloan in case he wants to chime in.

@joshlory
Copy link
Contributor Author

Thanks for adding that detail! Agree that the tertiary colors you chose (ff followed by 88) are nicer than the bit-flipped versions.

@joshlory joshlory merged commit 2c7a040 into staging Jan 23, 2019
@joshlory joshlory deleted the update-tint-color-list branch January 23, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants