Facilitator application csv

dashboard/app/controllers/api/v1/pd/applications_controller.rb

@@ -70,18 +70,8 @@ def quick_view
           render json: serialized_applications
         end
         format.csv do
-          if [:csd_teachers, :csp_teachers].include? role
-            csv_text = get_csv_text applications, role
-            send_csv_attachment csv_text, "#{role}_applications.csv"
-          else
-            prefetch applications, role: role
-            course = role[0..2] # course is the first 3 characters in role, e.g. 'csf'
-            csv_text = [
-              TYPES_BY_ROLE[role].csv_header(course, current_user),
-              *applications.map {|a| a.to_csv_row(current_user)}
-            ].join
-            send_csv_attachment csv_text, "#{role}_applications.csv"
-          end
+          csv_text = get_csv_text applications, role
+          send_csv_attachment csv_text, "#{role}_applications.csv"
         end
       end
     end
@@ -124,14 +114,8 @@ def cohort_view
           render json: serialized_applications
         end
         format.csv do
-          if [:csd_teachers, :csp_teachers].include? role.to_sym
-            csv_text = get_csv_text applications, role
-            send_csv_attachment csv_text, "#{role}_cohort_applications.csv"
-          else
-            optional_columns = get_optional_columns(regional_partner_value)
-            csv_text = [TYPES_BY_ROLE[role.to_sym].cohort_csv_header(optional_columns), applications.map {|app| app.to_cohort_csv_row(optional_columns)}].join
-            send_csv_attachment csv_text, "#{role}_cohort_applications.csv"
-          end
+          csv_text = get_csv_text applications, role
+          send_csv_attachment csv_text, "#{role}_cohort_applications.csv"
         end
       end
     end

dashboard/app/models/pd/application/application_base.rb

@@ -242,17 +242,16 @@ def additional_text_fields
 
     # Override in derived class to provide headers
     # @param course [String] course name used to choose fields, since they differ between courses
-    # @param user [User] requesting user - used to handle field visibility differences
     # @return [String] csv text row of column headers, ending in a newline
-    def self.csv_header(course, user)
+    def self.csv_header(course)
       raise 'Abstract method must be overridden by inheriting class'
     end
 
     # Override in derived class to provide the relevant csv data
-    # @param user [User] requesting user - used to handle field visibility differences
+    # @param course [String] course name used to choose fields, since they differ between courses
     # @return [String] csv text row of values, ending in a newline
     #         The order of fields must be consistent between this and #self.csv_header
-    def to_csv_row(user)
+    def to_csv_row(course)
       raise 'Abstract method must be overridden by inheriting class'
     end
 
@@ -369,7 +368,11 @@ def course_name
 
     # displays the iso8601 date (yyyy-mm-dd)
     def date_accepted
-      accepted_at.try {|datetime| datetime.to_date.iso8601}
+      accepted_at&.to_date&.iso8601
+    end
+
+    def date_applied
+      created_at.to_date.iso8601
     end
 
     # Convert responses cores to a hash of underscore_cased symbols

dashboard/app/models/pd/application/facilitator1920_application.rb

@@ -148,138 +148,50 @@ def self.filtered_labels(course)
       FILTERED_LABELS[course]
     end
 
-    # @override
-    def self.csv_header(course, user)
-      # strip all markdown formatting out of the labels
-      markdown = Redcarpet::Markdown.new(Redcarpet::Render::StripDown)
-      CSV.generate do |csv|
-        columns = filtered_labels(course).values.map {|l| markdown.render(l)}.map(&:strip)
-        columns.push(
-          'Status',
-          'Locked',
-          'General Notes',
-          'Notes 2',
-          'Notes 3',
-          'Notes 4',
-          'Notes 5',
-          'Question 1 Support Teachers',
-          'Question 2 Student Access',
-          'Question 3 Receive Feedback',
-          'Question 4 Give Feedback',
-          'Question 5 Redirect Conversation',
-          'Question 6 Time Commitment',
-          'Question 7 Regional Needs',
-          'Regional Partner'
-        )
-        csv << columns
+    # List of columns to be filtered out based on selected program (course)
+    def self.columns_to_remove(course)
+      if course == 'csf'
+        CSV_LABELS.keys.select {|k| k.to_s.start_with?('csd', 'csp')}
+      elsif course == 'csd'
+        CSV_LABELS.keys.select {|k| k.to_s.start_with?('csf', 'csp')}
+      else
+        CSV_LABELS.keys.select {|k| k.to_s.start_with?('csf', 'csd_training')}
       end
     end
 
-    def self.cohort_csv_header(optional_columns)
-      columns = [
-        'Date Accepted',
-        'Name',
-        'School District',
-        'School Name',
-        'Email',
-        'Status',
-        'Assigned Workshop'
-      ]
-      if optional_columns[:registered_workshop]
-        columns.push 'Registered Workshop'
-      end
-      if optional_columns[:accepted_teachercon]
-        columns.push 'Accepted Teachercon'
-      end
-
-      columns.push(
-        'General Notes',
-        'Notes 2',
-        'Notes 3',
-        'Notes 4',
-        'Notes 5',
-        'Question 1 Support Teachers',
-        'Question 2 Student Access',
-        'Question 3 Receive Feedback',
-        'Question 4 Give Feedback',
-        'Question 5 Redirect Conversation',
-        'Question 6 Time Commitment',
-        'Question 7 Regional Needs'
-      )
+    def self.csv_filtered_labels(course)
+      labels = {}
+      labels_to_remove = Pd::Application::Facilitator1920Application.columns_to_remove(course)
 
-      CSV.generate do |csv|
-        csv << columns
+      CSV_LABELS.keys.each do |k|
+        unless labels_to_remove.include? k.to_sym
+          labels[k] = CSV_LABELS[k]
+        end
       end
+      labels
     end
 
     # @override
-    def to_csv_row(user)
-      answers = full_answers
+    def self.csv_header(course)
+      # strip all markdown formatting out of the labels
+      markdown = Redcarpet::Markdown.new(Redcarpet::Render::StripDown)
       CSV.generate do |csv|
-        row = self.class.filtered_labels(course).keys.map {|k| answers[k]}
-        row.push(
-          status,
-          locked?,
-          notes,
-          notes_2,
-          notes_3,
-          notes_4,
-          notes_5,
-          question_1,
-          question_2,
-          question_3,
-          question_4,
-          question_5,
-          question_6,
-          question_7,
-          regional_partner_name
-        )
-        csv << row
+        columns = csv_filtered_labels(course).values.map {|l| markdown.render(l)}.map(&:strip)
+        csv << columns
       end
     end
 
-    def to_cohort_csv_row(optional_columns)
-      columns = [
-        date_accepted,
-        applicant_name,
-        district_name,
-        school_name,
-        user.email,
-        status,
-        fit_workshop_date_and_location
-      ]
-      if optional_columns[:registered_workshop]
-        if workshop.try(:local_summer?)
-          columns.push(registered_workshop? ? 'Yes' : 'No')
-        else
-          columns.push nil
-        end
-      end
-      if optional_columns[:accepted_teachercon]
-        if workshop.try(:teachercon?)
-          columns.push(pd_teachercon1819_registration ? 'Yes' : 'No')
-        else
-          columns.push nil
-        end
-      end
-
-      columns.push(
-        notes,
-        notes_2,
-        notes_3,
-        notes_4,
-        notes_5,
-        question_1,
-        question_2,
-        question_3,
-        question_4,
-        question_5,
-        question_6,
-        question_7
-      )
-
+    # @override
+    def to_csv_row(course)
+      columns_to_exclude = Pd::Application::Facilitator1920Application.columns_to_remove(course)
       CSV.generate do |csv|
-        csv << columns
+        row = []
+        CSV_LABELS.keys.each do |k|
+          unless columns_to_exclude.include? k.to_sym
+            row.push(full_answers[k] || try(k) || all_scores[k])
+          end
+        end
+        csv << row
       end
     end
 

dashboard/app/models/pd/application/facilitator_application_base.rb

@@ -96,6 +96,10 @@ def fit_workshop_date_and_location
       fit_workshop.try(&:date_and_location_name)
     end
 
+    def assigned_workshop_date_and_location
+      Pd::Workshop.find_by(id: pd_workshop_id)&.date_and_location_name
+    end
+
     def log_fit_workshop_change(user)
       update_status_timestamp_change_log(user, "Fit Workshop: #{fit_workshop_id ? fit_workshop_date_and_location : 'Unassigned'}")
     end
@@ -105,6 +109,14 @@ def registered_fit_workshop?
       fit_workshop.enrollments.any? {|e| e.user_id == user.id} if fit_workshop_id
     end
 
+    def friendly_registered_workshop(workshop_id = pd_workshop_id)
+      Pd::Enrollment.find_by(user: user, workshop: workshop_id) ? 'Yes' : 'No'
+    end
+
+    def friendly_registered_fit_workshop
+      friendly_registered_workshop(fit_workshop_id)
+    end
+
     def self.options
       {
         title: COMMON_OPTIONS[:title],
@@ -395,6 +407,10 @@ def destroy_fit_autoenrollment
       self.auto_assigned_fit_enrollment_id = nil
     end
 
+    def application_url
+      CDO.studio_url("/pd/application_dashboard/#{course}_facilitators/#{id}", CDO.default_scheme)
+    end
+
     # override
     def enroll_user
       super

dashboard/app/models/pd/application/teacher1920_application.rb

@@ -329,14 +329,6 @@ def check_idempotency
       Teacher1920Application.find_by(user: user)
     end
 
-    def date_applied
-      created_at.to_date.iso8601
-    end
-
-    def date_accepted
-      accepted_at&.to_date&.iso8601
-    end
-
     def assigned_workshop
       Pd::Workshop.find_by(id: pd_workshop_id)&.date_and_location_name
     end
@@ -378,7 +370,7 @@ def self.filtered_labels(course)
       FILTERED_LABELS[course]
     end
 
-    # Filter out extraneous answers based on selected program (course)
+    # List of columns to be filtered out based on selected program (course)
     def self.columns_to_remove(course)
       if course == 'csd'
         {