Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL search: update text for no regional partner found #26748

Merged
merged 1 commit into from Jan 26, 2019

Conversation

breville
Copy link
Member

Special information for Arkansas.

screenshot 2019-01-25 13 15 55

Special information for Arkansas.
Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Two questions - are we intending to show this Arkansas-specific message to every teacher who doesn't find a partner? And, it is slightly unclear to me if the above info about nearby regions applies to Arkansas teachers as well, or if they should only see the Arkansas info.

@breville
Copy link
Member Author

Good questions. I wondered the same, and was told that it was fine to show this content for all queries without a partner. There are only two, one of which is Arkansas.

@breville breville merged commit 5e036c0 into staging Jan 26, 2019
@breville breville deleted the pl-search-update-text branch January 26, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants