Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pegasus: vary page cache by country #26753

Merged
merged 1 commit into from
Jan 26, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cookbooks/cdo-varnish/libraries/http_cache.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ def self.config(env)
cookies: whitelisted_cookies
}
],
# Remaining Pegasus paths are cached, and vary only on language and default cookies.
# Remaining Pegasus paths are cached, and vary only on language, country, and default cookies.
default: {
headers: LANGUAGE_HEADER,
headers: LANGUAGE_HEADER + COUNTRY_HEADER,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is effectively the same as WHITELISTED_HEADERS but thought we might want to keep this separate in case that list grows in the future.

cookies: default_cookies
}
},
Expand Down