New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TeacherCon from cohort view #26761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment about naming, but otherwise this looks good to me!
def tc_registration | ||
# object is either an application (with possibly a linked TC registration), or itself a TC registration | ||
object.try(:pd_teachercon1819_registration) || object | ||
object.try(FIT_WEEKEND_REGISTRATION_FACTORY).try(:form_data_hash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create a new constant, since it doesn't make sense to be referring to a factory here
How test:
bundle exec rails test test/controllers/api/v1/pd/application/* test/models/pd/application/* test/controllers/pd/application/*