Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show button on announcements to learn more if no link provided … #26780

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Don't show button on announcements to learn more if no link provided … #26780

merged 3 commits into from
Jan 31, 2019

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jan 28, 2019

If an announcement does not have a link don't show the Learn More Button
screen shot 2019-01-28 at 4 33 51 pm
…for announcement

breville
breville approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we will receive null or undefined when there is no link, since this would still show the link if we received "". Given that we do the same check for buttonText, then this solution seems good.

Nice testing too!

@dmcavoy dmcavoy merged commit 5e1b908 into staging Jan 31, 2019
@dmcavoy dmcavoy deleted the announcement-button-hide branch January 31, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@maddiedierker maddiedierker maddiedierker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmcavoy @breville @maddiedierker