Remove WorkshopAutoenrolledApplication class #26789
Conversation
dashboard/app/models/pd/application/facilitator_application_base.rb
Outdated
Show resolved
Hide resolved
| include Pd::FacilitatorCommonApplicationConstants | ||
|
|
||
| serialized_attrs %w( | ||
| pd_workshop_id |
There was a problem hiding this comment.
should this just go on PdWorkshopHelper?
There was a problem hiding this comment.
Having this as a serialized attribute means that the models that use our helper would have to have a properties column and include (or the module could include) SerializedProperties. does that make this helper depend too much on the models? I am leaning towards keeping this in the models.
| serialized_attrs %w( | ||
| auto_assigned_enrollment_id | ||
| ) | ||
|
|
||
| # @override |
There was a problem hiding this comment.
I assume that this code will never get executed in real life again because it's 1819? If it is dead code, should we remove it completely instead of updating it? (I guess "removing" could be deleting the route configs so request won't hit this code path.)
There was a problem hiding this comment.
Since instances of these models still exist in our database, and at some point we plan to allow partners to download CSVs of their past applications, I want to preserve the data, including the associations between these models.
Currently, no routes are loading these applications.
clareconstantine
force-pushed
the
remove-ws-autoenroll-app
branch
from
8914597
to
dde2e4b
Compare
Previously, teacher and facilitator applications both inherited from
WorkshopAutoenrolledApplication, which inherited fromApplicationBase. We no longer have the concept of an autoenrollment, so I removed all code relating to autoenrolling and moved the remaining shared functionality into a module calledPd::Application::PdWorkshopHelper(open to better names - this module does caching as well) that bothTeacherApplicationBaseandFacilitatorApplicationBaseinclude.