Restore Auto project counter #26807
Merged
Restore Auto project counter #26807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty hash then use delete if
dmcavoy
changed the title
breville
reviewed
Jan 30, 2019
| Properties.set :metrics, { | ||
| created_at: time, | ||
| created_on: time.to_date, | ||
| petition_signatures: petition_signatures, | ||
| lines_of_code: lines_of_code, | ||
| project_count: Properties.get(:metrics)['project_count'], |
There was a problem hiding this comment.
Just a comment for future readers that this will lead to project_count being set to nil when it was previously not recorded at all. We have seen this in our test environments, for example, which has led to the delete_if added at https://github.com/code-dot-org/code-dot-org/pull/26807/files#diff-cfda98acedc510b51ec32e23bfad5d69R65
breville
approved these changes
Jan 30, 2019
breville
reviewed
Jan 30, 2019
lib/cdo/properties.rb
Outdated
| # When getting metrics: If metrics were to be nil we use the empty hash as delete_if | ||
| # does not work on nil. Delete_if deals with any specific values that come back nil and removes them so | ||
| # the merge will use the default values instead of a nil value. All of this makes sure each value in the hash | ||
| # is not zero or nil. |
There was a problem hiding this comment.
I would shorten the new comment to something like:
Note that project_count might be nil due to analyze_hoc_activity, and so we delete nil values prior to the merge, so that the merge doesn't overwrite our human-readable defaults with nil.
I'd also add a comment to analyze_hoc_activity with something like:
Note that project_count will be set to nil if it doesn't already exist. See the comment in fetch_metrics in lib/cdo/properties.rb where we handle this case when generating fallback human-readable default values.
maddiedierker
approved these changes
Jan 30, 2019
…vert-26702-auto-project-counter
breville
approved these changes
Jan 31, 2019
dmcavoy
deleted the
revert-26795-revert-26769-revert-26764-revert-26702-auto-project-counter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores #26702 by reverting #26795 with updates to fetch metrics function
Updated these 4 places (see below) on the website to have the project count get automatically updated.
We check on Sunday to see if the project count is a million higher than the current count and update the number used for display if it is.
These are both on the homepage:
This is on the projects page - both the index page and the public page.
