Add total attendance column to workshop dashboard for local summer workshops #26828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Jan 31, 2019
| @@ -6,6 +6,7 @@ import {workshopEnrollmentStyles as styles} from "../workshop_enrollment_styles" | |||
|
|
|||
| const CSF = "CS Fundamentals"; | |||
| const NA = "N/A"; | |||
| const LOCAL_SUMMER = "5-day Summer"; | |||
There was a problem hiding this comment.
Can we / should we be sharing these constants with the server code?
bethanyaconnor
approved these changes
Jan 31, 2019
islemaster
reviewed
Feb 20, 2019
islemaster
reviewed
Feb 20, 2019
clareconstantine
force-pushed
the
add-attendance-column
branch
from
60b5477
to
5f843f9
Compare
islemaster
approved these changes
Mar 8, 2019
| } |
There was a problem hiding this comment.
It'd be nice to get soundLibrary.json entirely out of this PR, but understandable if that's tricky at this point.
| workshopEnrollmentSchoolInfo | ||
| .find('th') | ||
| .filterWhere(col => col.text().includes('Total Attendance')) | ||
| ).to.have.length(0); |
There was a problem hiding this comment.
👍 I dig it. Thanks for adding additional coverage here!
added 5 commits
March 12, 2019 15:53
added 6 commits
March 26, 2019 12:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work for adding the scholarship dropdown - it will help partners decide which teachers will receive scholarships.
For each enrollee, display the number of sessions they have attended / the total number of sessions the workshop has.