Fix NoMethodError #26996
Merged
Fix NoMethodError #26996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
requested review from
islemaster and
hacodeorg
and removed request for
islemaster and
hacodeorg
islemaster
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
👍 Nice job tracking this down.
I'll suggest an alternative approach, but up to you which you like better: .reject(:nil?).reduce(:+) might be more expressive, but wouldn't handle it if, for example, we started passing false in this array.
Seems like we should get this urgent fix out, but following up with a small regression test would be good.
|
Sounds good - it's taking me a little while to pare down the test data to only the relevant pieces. |
joshlory
reviewed
Feb 12, 2019
| @@ -489,7 +489,7 @@ def generate_facilitator_averages(summary) | |||
| QUESTIONS_FOR_FACILITATOR_AVERAGES.each do |category, questions| | |||
| facilitator_averages[facilitator][category.to_s.downcase.to_sym] = {} | |||
| [:this_workshop, :all_my_workshops].each do |column| | |||
| average = (facilitator_averages[facilitator].slice(*(questions.map {|question| question[:primary_id]})).values.map {|x| x[column]}.reduce(:+) || 0) / questions.size.to_f | |||
| average = (facilitator_averages[facilitator].slice(*(questions.map {|question| question[:primary_id]})).values.map {|x| x[column]}.inject(0) {|sum, n| sum + (n || 0)} || 0) / questions.size.to_f | |||
There was a problem hiding this comment.
Why the rename from reduce -> inject? My understanding is they are aliased to each other.
Would be great to clean up this (already very long line) into a more readable set of statements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
.reduce(:+)on an array of nil values, which caused the user to see a 500 error and endless spinner.Fixed code rendering data that was previously erroring out:
