Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use UnsafeRenderedMarkdown component for ProgressLessonContent #27111

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 18, 2019

rather than rendering markdown manually

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- fewer examples of dangerouslySetInnerHTML for people to find and mistakenly think are legit!

// not providing for support for most markdown features (backticks being the
// exception). As such, we should not end up with actually dangerous markdown
// here.
console.log(description);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debug code

@Hamms Hamms merged commit 4980566 into staging Feb 19, 2019
@Hamms Hamms deleted the progresslessoncontent-markdown branch February 19, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants