PL: Regional Partner mini contact form #27166
Conversation
Conflicts: apps/Gruntfile.js
Conflicts: apps/script/checkEntryPoints.js apps/webpack.js
breville
requested review from
islemaster,
clareconstantine,
hacodeorg,
poorvasingal and
tanyaparker
| 'tutorialExplorer', | ||
| 'regionalPartnerSearch', | ||
| 'regionalPartnerMiniContact' | ||
| ) |
There was a problem hiding this comment.
@davidsbailey You've got the most recent knowledge on JS build configuration - does this make sense?
There was a problem hiding this comment.
no -- this doesn't look right, because only locale-related files should be added here. were you getting an error without adding these here, @breville ?
There was a problem hiding this comment.
sorry... I misread. seems like you are just adding 'regionalPartnerMiniContact' which follows the existing pattern, so this looks good to me. I'm not sure what a better pattern would be but at least this way we only have one pattern to clean up later (if that turns out to be needed).
so this line LGTM
apps/src/code-studio/pd/regional_partner_mini_contact/RegionalPartnerMiniContact.jsx
Outdated
Show resolved
Hide resolved
| defaultValue={this.state.notes} | ||
| /> | ||
| {!this.state.submitting && ( | ||
| <Button id="submit" onClick={this.submit}> |
There was a problem hiding this comment.
Worth adding a disabled={this.state.submitting} or something?
There was a problem hiding this comment.
Good question. The current implementation just replaces the button with a spinner while submitting (the line above hides the button). I suspect we'll do a UI refresh before launching this and I'll make it nice then.
| id="notes" | ||
| label="Questions or notes for your local Regional Partner" | ||
| type="text" | ||
| componentClass="textarea" |
There was a problem hiding this comment.
This is where user enters question which could be in form of a short email. Should we make the text area bigger?
There was a problem hiding this comment.
Good question. We can also address this in a UI pass soon. The control is responsive and so it might depend on how big we want it to be overall. The user can also resize it manually already.
|
@breville Dropped me a note to ask if these email addresses would inadvertently get collected by our Contact Rollups process. I don't see any reference to this new |
|
This PR should have included #27215. |
This is a "mini" contact form for a regional partner. It works similarly to the regular "Contact a Regional Partner" form at https://studio.code.org/pd/regional_partner_contact/new but is much easier to fill out. It has four fields - name, email, school zip, and notes - but only email and school zip are required.
It's designed to have as many fields filled out as possible. For example, a signed-in teacher should see all four fields filled out, with name and email coming from the user profile, and school zip coming from the user's associated school.
On the backend, there is a new model (
Pd::RegionalPartnerMiniContact) to store the results because it has less to validate than the existing model (Pd::RegionalPartnerContact). It uses the same mailer (Pd::RegionalPartnerContactMailer) but some modifications have been made to cope with the fewer fields available. The submitted school zip code is used to look up the matching regional partner.The form is designed to work on both dashboard and pegasus. For pegasus, a new dashboard route has been added (
/api/v1/users/:user_id/contact_details) to retrieve the contact details that will be pre-populated.The form is not yet shown publicly. It is available to use on two test URLs:
screenshot:
Also there are no tests yet.