Mini Rubric: RubricField subcomponent #27175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmcavoy
commented
Feb 21, 2019
•
dmcavoy
commented
- Created a sub-component that does the checkbox and details tag for each performance level of the rubric.
- Created a sub-component that hold the teacher feedback area.
- Made it so students do not see the feedback tab if they have been given feedback in the past but the most recent feedback has no performance or comment value.
- Made it so student only sees the section of the feedback tab they got feedback on. For example, if there is no comment given but the rubric is filled out it will only show the rubric area.
…edback and both rubric and comment are blank
dmcavoy
changed the title
…he header. Moved student feedback time to use the same time display for teachers for now
|
👀 looking... |
There was a problem hiding this comment.
Nice changes Dani! The RubricField extraction really cleans things up!
I am feeling some guilt about the guidance I've given you on extracting the CommentArea, because what you've ended up extracting there does not greatly reduce the amount of code needed in this file to define the comment area. Sorry about that 😳 I think these changes still look fine, since there's nothing wrong with having this extracted, and I agree that it doesn't really make sense to pull the Button or other things into the extracted component, though.
davidsbailey
approved these changes
Feb 22, 2019
maddiedierker
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.