Fix print logins #27213
Merged
Fix print logins #27213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Feb 25, 2019
| @@ -226,7 +227,6 @@ class WordOrPictureLogins extends React.Component { | |||
| printWindow.document.write('<body onafterprint="self.close()">'); | |||
| printWindow.document.write(printArea); | |||
| printWindow.document.write('</body></html>'); | |||
| printWindow.print(); | |||
There was a problem hiding this comment.
😂 I wonder if we'll get complaints about this. Either way, I think it's worth a shot and we can do something more complicated around waiting for all images to load later, if we really need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP-148 (logged after the fact for tracking purposes).
Found 2 small bugs while testing
/login_infofor picture sections:printWindow.print()when the print window opens causes the students' secret pictures to not load. Solution: Don't automatically call.print(). This means the teacher will have to print themselves, which I assume they know how to do, but there may be a better solution for this.pageBreakInside: 'avoid'for login cards.