Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-style change password page #27222

Merged
merged 2 commits into from Feb 27, 2019
Merged

Re-style change password page #27222

merged 2 commits into from Feb 27, 2019

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Feb 25, 2019

Applying styles from the sign in form to the change password form, and removing OAuth links from the form.

Before

Introduced the new OAuth buttons in #27218 last night, but the styling was... not great:
screen shot 2019-02-25 at 8 05 44 am

After

screen shot 2019-02-26 at 9 52 38 am

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want users in the middle of a change password process to ever switch to an OAuth flow instead? I wonder if we should just remove these buttons from that page instead.

@maddiedierker
Copy link
Contributor Author

@islemaster great point, i am all for just removing those links -- they don't make sense to me either. i'll email JoshS and Marina about this to get their input. i'd still like to merge this PR in the meantime since the UX is pretty bad right now

@maddiedierker
Copy link
Contributor Author

@islemaster PTAL! Poorva and Marina agreed that we should just remove those links. (i updated the image in the PR description to match)

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 So much better!

@maddiedierker maddiedierker merged commit ca779d8 into staging Feb 27, 2019
@maddiedierker maddiedierker deleted the style-change-password branch February 27, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants