Teacher app: Rescore taught in past #27287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
changed the title
hacodeorg
approved these changes
Feb 28, 2019
Hamms
reviewed
Mar 1, 2019
| @@ -505,7 +505,7 @@ def auto_score! | |||
| meets_scholarship_criteria_scores[:previous_yearlong_cdo_pd] = responses[:previous_yearlong_cdo_pd].exclude?('CS Principles') ? YES : NO | |||
| end | |||
|
|
|||
| bonus_points_scores[:taught_in_past] = responses[:taught_in_past] == [options[:taught_in_past].last] ? 2 : 0 | |||
| bonus_points_scores[:taught_in_past] = (responses[:taught_in_past] & options[:taught_in_past].values_at(3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 15)).any? ? 0 : 2 | |||
There was a problem hiding this comment.
Relying on the indexes here seems unnecessarily fragile. Could this be pulled out into a helper method that's more explicit about the values we care about?
bin/oneoff/rescore_taught_in_past
Outdated
|
|
||
| # append to the file as we go, so that in case we encounter an exception and exit early, | ||
| # we have a record of the applications we've updated. | ||
| File.open('rescored_applications', 'a') do |list| |
There was a problem hiding this comment.
nit; this should probably be in /tmp/
Hamms
reviewed
Mar 7, 2019
bin/oneoff/rescore_taught_in_past
Outdated
| response_scores = JSON.parse(application.response_scores) | ||
|
|
||
| old_taught_in_past_score = response_scores["bonus_points_scores"] ? response_scores["bonus_points_scores"]["taught_in_past"] : nil | ||
| new_taught_in_past_score = (responses[:taught_in_past] & options[:taught_in_past].values_at(3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 15)).any? ? 0 : 2 |
There was a problem hiding this comment.
nit: this should probably also use TAUGHT_IN_PAST_NO_BONUS_POINT_RESPONSES, although fragility for a one-off script is much less frightening
| raise | ||
| end | ||
|
|
||
| File.open('./tmp/rescored_applications', 'w') do |file| |
Hamms
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescore the question about what CS courses you've taught previously to give bonus points if their answer doesn't include anything except:
There is a script to rescore previous applications and produce a list of the changed applications sorted by regional partner for Anthonette to notify partners.