Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make match levels draggable within level groups #27296

Merged
merged 4 commits into from Apr 9, 2019
Merged

Make match levels draggable within level groups #27296

merged 4 commits into from Apr 9, 2019

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Feb 28, 2019 •
edited

Background

Description

Enables match levels within level groups as follows:

  • extracts drag/drop code and applies it to match levels in level groups
  • disables sounds when in level group
  • configures drag/drop to isolate multiple match levels from each other within a single level group page

Testing

existing test coverage verifies that I did not break exising match levels. tests will be added for match levels in level groups once they are working end-to-end, which includes saving / loading student choices like we do for multi levels.

screencast

match-after

@davidsbailey davidsbailey changed the base branch from staging to level-group-match February 28, 2019 06:54
@davidsbailey davidsbailey changed the base branch from level-group-match to staging February 28, 2019 21:25
@davidsbailey davidsbailey force-pushed the match-lg-drag branch 2 times, most recently from 1d8f854 to fd1a5d3 Compare April 8, 2019 16:56
@davidsbailey davidsbailey changed the title WIP: Match lg drag Make match levels draggable within level groups Apr 8, 2019
islemaster
islemaster approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I love the containment behavior.

@davidsbailey davidsbailey merged commit c278812 into staging Apr 9, 2019
@davidsbailey davidsbailey deleted the match-lg-drag branch April 9, 2019 00:12
@davidsbailey davidsbailey mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @islemaster