Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gamelab debugger line numbers by accounting for hidden sharedBlocks and helperLibraries #27360

Merged

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Mar 4, 2019

  • When various commits added "invisible" code above the user's code in Gamelab (validation code, helper libraries, shared blocks), they broke the debugger's calculation of line numbers for highlighting code and enforcing breakpoints. Fortunately, we have a feature within the interpeter/debugger for handling this case (called userCodeStartOffset), so we just need to wire it up in gamelab so we can get the desired effect.

@cpirich cpirich requested a review from joshlory March 4, 2019 22:37
@joshlory joshlory requested a review from jmkulwik March 5, 2019 21:54
@cpirich cpirich merged commit bb1bfb5 into staging Mar 6, 2019
@cpirich cpirich deleted the cpirich/fix-gamelab-debugger-by-using-userCodeStartOffset branch March 6, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants