Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teacher panel section link #27381

Merged
merged 3 commits into from Mar 7, 2019
Merged

Teacher panel section link #27381

merged 3 commits into from Mar 7, 2019

Conversation

maddiedierker
Copy link
Contributor

What it does

  • Adds a link to teacher dashboard for the current section on the script overview page teacher panel.
  • Refactors the teacher panel to make all of the content scrollable (rather than only the StudentTable portion). Originally, we were calculating the height of the StudentTable, which proved to be brittle once I added another element to the teacher panel. Making all of the content scrollable makes the solution more robust.

Before

screen shot 2019-03-05 at 3 46 42 pm

After

Section with few students (i.e., no scrolling overflow):
screen shot 2019-03-05 at 3 13 32 pm

Section with more students (i.e., with scrolling overflow):
screen shot 2019-03-05 at 3 14 08 pm

dmcavoy
dmcavoy approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

islemaster
islemaster approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems simpler!

@maddiedierker maddiedierker merged commit 30d52b1 into staging Mar 7, 2019
@maddiedierker maddiedierker deleted the teacher-panel-links branch March 7, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcavoy dmcavoy dmcavoy approved these changes

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maddiedierker @dmcavoy @islemaster