Deeper learning: Remove deprecated UI #27407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
approved these changes
Mar 7, 2019
| @@ -11,7 +11,6 @@ export default storybook => { | |||
| name: 'Escalated Peer Review Submissions', | |||
There was a problem hiding this comment.
How are these stories different now, if both have the escalated status for all the submissions?
There was a problem hiding this comment.
🤦♂️ Great catch - they're not! I'll tear one out.
| status: 'escalated', | ||
| accepted_reviews: 1, | ||
| rejected_reviews: 0 | ||
| status: 'escalated' |
There was a problem hiding this comment.
How do we get in a state where the status is 'escalated' but escalation_date is undefined?
There was a problem hiding this comment.
I'm not sure - this may not be a representative story. I'll review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two UI changes to the peer review dashboard. (PLC-67, spec)
Remove the "Escalated" and "Open" tabs.
Actually, remove the tabs entirely since we only care about the "All Submissions" view now. I've also removed this filter option from the API, since it's now unused.
Remove the "Accepted submissions" and "Rejected submissions" columns.
These columns aren't useful in the workflow this year and they take up quite a bit of space. I've also removed these counts from the summary data returned by the API.
Before:
After:
Done now, because it was fairly easy to do this cleanup while investigating and fixing a different Deeper Learning issue, in #27406.