Remove unused Honeybadger notification #27432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query and notification in User#track_level_progress_sync always runs right after PeerReview.create_for_submission, which is guaranteed to create two peer reviews if it creates any at all. That would explain why we've never run this notification. If we _do_ fail to create peer reviews, it will be because of an exception causing the wrapper transaction to roll back, and the transaction wrapper would re-raise the exception so it would end up in Honeybadger anyway.
islemaster
force-pushed
the
remove-unused-hb-notification
branch
from
4d6c024
to
d8fc639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query and notification in User#track_level_progress_sync always runs right after PeerReview.create_for_submission, which is guaranteed to create two peer reviews if it creates any at all. That would explain why we've never run this notification.
If we do fail to create peer reviews, it will be because of an exception causing the wrapper transaction to roll back, and the transaction wrapper would re-raise the exception so it would end up in Honeybadger anyway.