Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Rubric: Sizing of key concept vs rubric area #27463

Merged
merged 2 commits into from Mar 12, 2019
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Mar 12, 2019

Fixes the sizing of the key concepts vs the rubric area in the feedback tab of the instructions area.

Before

Some places looked okay but especially in a web lab level something about the sizing was off.
Screen Shot 2019-03-12 at 10 39 54 AM

After

App Lab

Screen Shot 2019-03-12 at 10 35 46 AM

Web Lab

Screen Shot 2019-03-12 at 10 44 25 AM

Screen Shot 2019-03-12 at 10 36 44 AM

Screen Shot 2019-03-12 at 10 36 27 AM

Game Lab

Screen Shot 2019-03-12 at 10 36 19 AM

Screen Shot 2019-03-12 at 10 36 51 AM

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but the sizing still looks different in weblab. it should be possible to use the Chrome element inspector to figure out what other styles related to sizing are affecting the text elements in weblab, and then add styles to override them to make them look more like applab. (or, there may be a style in applab that you're depending on which doesn't exist in weblab).

@davidsbailey
Copy link
Member

Ahh, sorry, I just noticed that the applab / weblab images are different sizes. nothing left to do then as long as the text is appearing as the same size in both apps.

@dmcavoy dmcavoy merged commit dc53411 into staging Mar 12, 2019
@dmcavoy dmcavoy deleted the rubric-sizing branch March 12, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants