use snack-sdk 2.2.0-apkurl-v1 and add to toTranspileWithinNodeModules #27488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Mar 13, 2019
@islemaster I believe it is because of this: https://github.com/code-dot-org/code-dot-org/blob/staging/apps/test/unit/applab/ExporterTest.js#L772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2.0-apkurl-v2version of thesnack-sdkto work around a transpiling issue. When I had tried adding this package totoTranspileWithinNodeModuleslocally, it didn't fix myyarn test:unitrun. But, it turns out that our tests require anappsbuild first - and that needed to be done with the new webpack config before the test error went away. So, now I've made the change and converted us back to the2.2.0-apkurl-v1version which is close to the mainlinesnack-sdk(it just includes the changes from Apk url expo/snack-sdk#9)