New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTL (Test > Levelbuilder): c70b9398 #27503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use FileUtils, but not required.
fixing a spelling error CSP unit 2 chapter 2 flex category
Add message for keyPress validation in dance 10 and 11
… are created already-migrated
…Collect, Human, and Nature
…ransition will be uploaded in a diff commit because of how the original folders with .wav files were separated
…sers are now created already-migrated
Remove no_firefox tag for flakiness
DTT (Staging > Test) [robo-dtt]
The DownloadReplayVideoButton component, which is reponsible for creating and downloading the replay videos in Dance Projects, is included even for non-Dance projects but is smart enough not to render itself unless it identifies that it is actually needed (ie, if the current project is a Dance project). Unfortunately, we _also_ start a thread that checks to see whether or not the video already exists, and that thread was happening regardless of whether or not the component renders. Adding a simple sanity check to the controlling method is sufficient to prevent those unnecessary network requests.
require 'fileutils'
DTT (Staging > Test) [robo-dtt]
…d-in-dance Only check for video downloads for Dance projects
DTT (Staging > Test) [robo-dtt]
I18n sync Down & Out 03/12
DTT (Staging > Test) [robo-dtt]
Update EC2 instance-profile roles to use fine-grained permissions
DTT (Staging > Test) [robo-dtt]
Lesson extras landing
DTT (Staging > Test) [robo-dtt]
Removes the nightly `backfill_missing_peer_reviews` cronjob, originally introduced in #26638 as a mitigation for a bug that was recently resolved in #27406. This fix shipped in [v2019-03-07.0](https://github.com/code-dot-org/code-dot-org/releases/tag/v2019-03-07.0) and since then we've had five nights in a row where no backfill was needed, including three weeknights where we've previously seen steady backfill activity. At this point it looks like this workaround is no longer needed and we can remove it!
DTS (Levelbuilder > Staging) [robo-dts]
Remove unused Section#add_and_remove_student
Level builder changes
DTT (Staging > Test) [robo-dtt]
add production RDS DB parameter group to Data stack template
…peer_reviews Deeper Learning: Remove nightly PeerReview backfill
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.