Mini Rubric: Keep Feedback When Switching Tabs #27507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack that has not been saved
maddiedierker
approved these changes
Mar 14, 2019
| @@ -237,8 +244,14 @@ class TeacherFeedback extends Component { | |||
|
|
|||
| const rubricLevels = ['exceeds', 'meets', 'approaches', 'noEvidence']; | |||
|
|
|||
| // Instead of unmounting the component when switching tabs hide and show it | |||
| // so a teacher does not lose the feedback they are giving if they switch tabs | |||
| const tabArea = this.props.visible | |||
There was a problem hiding this comment.
super nit: rename tabArea to something like tabVisible for clarity
davidsbailey
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now don't unmount feedback tab when switching tabs. This allows us to keep all the state information with the Teacher Feedback Tab but also not lose unsaved feedback if a teacher wants to read the instructions in the middle of writing feedback.