Instructions Tab: Only Force Resize for Feedback Tab #27571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -209,7 +209,9 @@ class TopInstructions extends Component { | |||
| * contents of the comment tab. | |||
| */ | |||
| forceTabResizeToMaxHeight = () => { | |||
| this.props.setInstructionsRenderedHeight(this.adjustMaxNeededHeight()); | |||
| if (this.state.tabSelected === TabType.COMMENTS) { | |||
There was a problem hiding this comment.
i think rather than checking this.state.tabSelected === TabType.COMMENTS here, we should instead not be calling forceTabResizeToMaxHeight unless we are on the comments tab. i know you're trying to get this out for the deploy, so non-blocking, but should be refactored later
There was a problem hiding this comment.
Ok I will refactor tomorrow.
There was a problem hiding this comment.
After discussion, this is the best way to do this for now so not refactoring
maddiedierker
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow force resize of tab when it's the comments tab.
Before
After