Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename survey results columns #27581

Merged
merged 7 commits into from Apr 2, 2019
Merged

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented Mar 19, 2019

PLC-52 / PLC-40
Change the facilitator survey results' right column (related workshops) header to reflect the data we are currently showing to users. If you have multiple of these permissions, you see whichever thing comes first in this list.

If you are a workshop admin, you see...
Screen Shot 2019-03-18 at 5 59 40 PM

If you are a program manager, you see...
Screen Shot 2019-03-18 at 6 00 28 PM

If you are a workshop organizer (note: this permission has been deprecated), you see...
Screen Shot 2019-03-18 at 5 58 00 PM

If you are a facilitator, you see...
Screen Shot 2019-03-18 at 6 01 05 PM

@breville
Copy link
Member

Should the "June 2018" be dynamic in any way, or it will it stay that date forever?

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code appears to match the described behaviour.

@clareconstantine
Copy link
Author

Should the "June 2018" be dynamic in any way, or it will it stay that date forever?

@breville I have a task to update this page to add a dropdown to show results per-year, so those headers will change, but in general that date is the date we switched from pegasus to jotform so it isn't dynamic.

@clareconstantine clareconstantine merged commit e016d40 into staging Apr 2, 2019
@clareconstantine clareconstantine deleted the rename-survey-results-columns branch April 2, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants