Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused empty string #27649

Merged
merged 1 commit into from Mar 25, 2019
Merged

Delete unused empty string #27649

merged 1 commit into from Mar 25, 2019

Conversation

nkiruka
Copy link
Contributor

@nkiruka nkiruka commented Mar 22, 2019

This PR is a follow up to PR# 27511. "Hoc2018_minecraft_aquatic_title2" is not defined anywhere in the code.

Before:

Screen Shot 2019-03-22 at 2 16 14 PM

After:

Screen Shot 2019-03-22 at 2 26 18 PM

The removal of the line break does not affect the layout of the card.

@breville
Copy link
Member

As discussed, suggest PR title "Delete unused Minecraft string" -> "Remove use of non-existent string" or similar.

@nkiruka nkiruka changed the title Delete unused Minecraft string Delete unused empty string Mar 22, 2019
@breville
Copy link
Member

Does the removal of the %br/ affect the layout in any way?

If so, before/after screenshot would be good.

@nkiruka
Copy link
Contributor Author

nkiruka commented Mar 22, 2019

@breville PR updated with screenshots. Thanks

@nkiruka nkiruka merged commit 5713eab into staging Mar 25, 2019
@nkiruka nkiruka deleted the remove-unused-mc-string branch March 25, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants