add oneoff script for incrementally migrating users to multi auth #27687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
commented
Mar 25, 2019
| def migrate_batches(limit=nil) | ||
| limit = limit.to_i if limit | ||
| unmigrated_users = User.where.not(provider: User::PROVIDER_MIGRATED) | ||
| unmigrated_users_count = 40_000_000 # estimate |
There was a problem hiding this comment.
estimated this via an SQL select on the reporting DB.
islemaster
reviewed
Mar 26, 2019
|
|
||
| def migrate_batches(limit=nil) | ||
| limit = limit.to_i if limit | ||
| unmigrated_users = User.where.not(provider: User::PROVIDER_MIGRATED) |
There was a problem hiding this comment.
Do we need to with_deleted include soft-deleted users, or are we officially leaving those behind?
There was a problem hiding this comment.
My plan is to leave them behind, then wait 30 days after this script finishes to begin tearing out support for nonmigrated users to ensure that they are fully gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to run this against production data a slice or two at a time, to verify that users migrate as expected, before running it against all remaining unmigrated users.