Account Deletion: Limit confirmation email size #27690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udents deletes their account
islemaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FND-324, Slack: Fixes recent occurrences of Honeybadger 37298089. We had a teacher with over 1,700 students delete their account and the dependent student accounts, and the JSON blob containing the resulting email body overflowed the
pegasus.poste_deliveriestext(65535) columnparams, causing an error when we later tried to parse this JSON in order to send it.Solution: Don't list every student in the email if a teacher with more than 1000 students deletes their account.