replace dangerouslySetInnerHtml in GeneratedCode with UnsafeRenderedMarkdown #27695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
update-html-in-generatedcode
branch
from
55102b4
to
1d2e859
Compare
islemaster
reviewed
Mar 26, 2019
| /> | ||
| <pre className="generatedCode" dir="ltr"> | ||
| {this.props.code} | ||
| </pre> |
There was a problem hiding this comment.
I take it this dangerouslySetInnerHTML was never needed for props.code?
There was a problem hiding this comment.
As far as I can tell, that's correct! The content in here comes from codegen, which never uses html characters.
Which also makes sense; there's no reason to dangerouslySetInnerHTML on a pre tag, since it would just be ignored anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of our overall dSIH deprecation effort
Also requires a styling change, since we're changing the
.generatedCodeMessageelement from a paragraph to a div.