Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open url block to toolbox #27704

Merged
merged 1 commit into from Mar 26, 2019
Merged

Add open url block to toolbox #27704

merged 1 commit into from Mar 26, 2019

Conversation

epeach
Copy link

@epeach epeach commented Mar 26, 2019

Adding the new open url block to the toolbox as a UI Control button per: https://docs.google.com/document/d/1cW1OiVLmXhAzBU4MSNM0q6g3UA5zZTZapQgUMxp3V84/edit

Screenshot from 2019-03-26 10-29-09

Copy link
Contributor

@ajpal ajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this need to be behind the experiment flag?

@epeach
Copy link
Author

epeach commented Mar 26, 2019

@ajpal Per discussion in Applab channel, we are ready to release at large. :)

@kimj42
Copy link
Contributor

kimj42 commented Mar 26, 2019

Looks great! Cool to see that's how we add blocks to the toolbox!

@epeach epeach merged commit cc071e5 into staging Mar 26, 2019
@epeach epeach deleted the open-block-toolbox branch July 2, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants