Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up large eyes test files #27743

Merged
merged 3 commits into from Mar 28, 2019
Merged

split up large eyes test files #27743

merged 3 commits into from Mar 28, 2019

Conversation

davidsbailey
Copy link
Member

In a recent eyes test run, two eyes test files stood out as taking almost 20 minutes:

Screen Shot 2019-03-28 at 10 14 29 AM

Split up these largest tests so that no one test takes more than about 10 minutes.

breville
breville approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nothing changed beyond the major moves, this looks great!

@davidsbailey davidsbailey merged commit 0125103 into staging Mar 28, 2019
@davidsbailey davidsbailey deleted the eyes-csf branch March 28, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @breville