use level type whitelist during level creation #27783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
lc-constantize
branch
from
d78bfb1
to
90db420
Compare
islemaster
added a commit
that referenced
this pull request
Sep 4, 2019
Return to an approach considered in #27783 to resolve an issue where `Level.descendants` doesn't reliably list all level classes since they may not have been autoloaded yet shortly after the server restarts. This approach avoids that issue by explicitly listing them, which unfortunately is less DRY but is a lot less action-at-a-distancey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://codedotorg.atlassian.net/browse/XTEAM-105 for problem and the motivation for this solution.